Henry Schreiner

Results 2507 comments of Henry Schreiner

I'd probably put something like this in a non-Python file, say `pyproject.toml` under `[tool.nox] requires=["GitPython==3.1.14"]`, etc. Sounds like it would be a rather large change, though, since nox would need...

So the behavior could be: * If either is None, use the other one. * If either is False, don't reuse venvs. * Otherwise, reuse if one or both are...

There is a very easy workaround for the above, though - don't set `nox.options.reuse_existing_virtualenvs = False` (or set it to none). This gives you a quick way to drop a...

I think this is what you meant, but just to be clear: I'd leave the session option as `reuse_venv=True/False(/None, implicit)`, then: * Command-line `--reuse=yes` reuses envs for all sessions except...

And then some deprecation/removal of `nox.options.reuse_existing_virtualenvs`, maybe being mapped to `nox.options.reuse` for a bit?

I do like `--reuse-venv=` or `--reuse=` better, as the current name is very cumbersome and will be even longer when `=` is added. Also, changing it to an option from...

Also, `@nox.session(reuse_venvs="always"):` and `@nox.session(reuse_venvs="never"):` would be invalid, they can be overridden by the command line option, so they aren't "always" and "never".

> There is lots of precedence for this in existing Python code. This is fine when it's needed. I'm aware of Literals, python's string comparisons for short strings, etc. My...

If you wanted strings for reuse_venv, "default", "no", and "yes" would be identical to "no", "never", and "yes"/"always" (there is no difference between "yes" and "always" when set locally, by...

I guessed as much :) And, since you are updating examples, I've found that the following is ideal for adding googletest: ```cmake # CMake warning suppression will not be needed...