Henry Schreiner
Henry Schreiner
The links for the PDF libraries are different in 3.16; this part disappears: ``` -L/usr/local/cuda/targets/x86_64-linux/lib ../../../src/PDFs/basic/libPDFBasic.a ../../../src/PDFs/combine/libPDFCombine.a ../../../src/PDFs/physics/libPDFPhysics.a ../../../src/PDFs/libPDFCore.a ../../../src/goofit/libApplication.a ../../../src/goofit/libFaddeeva.a ../../../src/goofit/libFunctorWriter.a ../../../src/goofit/libPdfBase.a ../../../src/goofit/libFitManager2.a ../../../src/goofit/libDataSet.a ../../../src/goofit/libVariable.a ../../../extern/Minuit2/src/libMinuit2.a ../../../extern/Minuit2/src/math/libMinuit2Math.a ../../../extern/FeatureDetector/src/x86/libFeatureDetector.a ../../../extern/fmt/libfmt.a...
I've started a build with 3.16.2, though I think this fix was back ported into 3.15.7, and I tested that one when 3.15.7 came out and it worked (I was...
No, it did not build with 3.16.2. It builds correctly with 3.15.7, which has the same fix back ported.
I'll try, but I'm traveling this week. Now that I know roughly what is different it will be easier to set up.
ROOT has dropped support for anything less than CMake 3.9, expect GooFit to follow suit soon.
Conda package done.
FYI: I was checking 3.15.7 since I saw a change that looked like it could affect us; since 3.16 doesn't work and I don't know why, I'm being careful! Trying...
Okay, now there's a GCC 9 Internal Compiler Error. 🤣
Why can't we just make it optional when building; in fact, if we just pass `-DCUDA_RESOLVE_DEVICE_SYMBOLS=ON` when configuring, I think no changes are needed at all, save to documentation?
No, I take that back. This is only a property target: https://cmake.org/cmake/help/latest/prop_tgt/CUDA_RESOLVE_DEVICE_SYMBOLS.html Also, it seems it is doing something slightly different than I thought. As long as it doesn't break...