Henry Schreiner
Henry Schreiner
Ahaha, I bet this is what's breaking CMake: https://github.com/scikit-build/scikit-build/pull/673 (at least it's a start)
It should also be available in the `v2.9` branch. Hopefully we can cut a new patch release soon.
The library name change in 3.9 is also likely breaking things, though, possibly including all older versions of CMake's FindPython support. I want to look into that before making a...
We don't want to break the normal way to install this (via pip), so not fond of adding a new file. Also this would probably not be relocatable? The wheel...
Okay, now I'm confused. `pybind11-config` is not part of the CMake install at all. It's a Python entry point so it can only be installed via Python. It's not generated...
I'm happy to help with the CMake setup if this continues. :)
I think `.inc` is used sometimes, but may not get nice highlighting in some editors. fmtlib uses `-inl.h`, which I think is my favorite. `/src` then has `cpp` files that...
> I would not recommend splitting yet another file to reduce maintenance overhead. I don't like the idea of having an `#include ` file, or `*.cpp` files being distributed as...
I'm still in favor of `-inl.h` because: a) having a .cpp file in `/include` and shipped with your library in packaging is odd, b) compilers sometimes complain if you put...
The automated tests build on the PR merged with the branch it's targeting. So if there are conflicts, it can't run. You can manually run form your fork, though, just...