Henry Wang

Results 38 comments of Henry Wang

It's probably the time to formally address this issue now for containerd v1.6.0 release. The task creation logic [here](https://github.com/containerd/containerd/blob/v1.6.0/services/tasks/local.go#L236) needs a PID from shim. And the new logic in [shim...

> This PR is proposing a mapping between an Image and the Platform, but we may still get to the case that one specific Platform uses different snapshotters there. In...

> > > This PR is proposing a mapping between an Image and the Platform, but we may still get to the case that one specific Platform uses different snapshotters...

From the stack trace the container [spec](https://github.com/containerd/containerd/blob/v1.7.2/services/tasks/local.go#L200) seems to be NIL. Adding an extra nil value check would prevent the segfault. However a container cannot run without a valid spec....

The unit test below didn't result in any error to me (with v1.7.5). Do you mind running it on your end? ``` func TestMetrics(t *testing.T) { m := &v1.Metrics{ CPU:...

I think https://github.com/containerd/containerd/pull/9112 might be the fix to this issue. @matray is it likely for you to verify the patch in your environment?

Makes sense. Just want to understand any potential impact to GC, since we may end up with multiple contents referencing the same snapshot. If we remove one of the images,...

@swagatbora90 is still working on this. Reopen this PR to continue to work.