Henrik Skov Midtiby
Henrik Skov Midtiby
Thanks for the tip about `InternalPoint3D`. It enabled me to reduce the number of errors reported by mypy in the mobject directory to 1707. For reference my first run of...
@JasonGrace2282 Ok, status is that 21 errors are currently reported by mypy in the `manim/mobject/geometry` directory. So now the real detective work starts ... ``` $ mypy manim/mobject/geometry/tips.py:152: error: Returning...
@JasonGrace2282 I would like a set of fresh eyes to look at this PR The status is that mypy now reports three type errors (listed below). I think that finding...
> For the first error, I'm not quite sure why mypy complains - does it think that `buff=buff` conflicts with `**kwargs`? > I think it's safe to ignore that error....
@JasonGrace2282 Current status is that I have zero type errors according to mypy (version 1.11.1) on my computer. When I earlier activated mypy on the CI workflow [link](https://github.com/ManimCommunity/manim/pull/3961/commits/d477c9a99493a85f683a5ee0cb6098835bc6b42e), it found...
> I did leave some comments/questions, so it would be nice to work towards getting those worked out so that everyone can enjoy the benefits of IDE completion :) Thanks...
@JasonGrace2282 I think we are close to merging the pull request. Will you take a look? It seems like the CI flow does not activate the tests, they are listed...
> I would like to handle this PR eventually. > > In the meantime, @henrikmidtiby, PR #4115 completely rewrote the `Code` mobject to make its code much cleaner. We already...
@JasonGrace2282 Would you take a look at this PR?
I would suggest to move all the interpretation of the `windows_size` value into the config file and then skip parsing these values in the constructor for the `Window` class in...