manim icon indicating copy to clipboard operation
manim copied to clipboard

Typing mobject text

Open henrikmidtiby opened this issue 10 months ago • 2 comments

Overview: What does this pull request change?

This pull request will add types to mobject/text/*.py

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

I indent to use this PR to share progress and get input on things that show up.

Reviewer Checklist

  • [ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • [ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • [ ] If applicable: newly added functions and classes are tested

henrikmidtiby avatar Jan 06 '25 08:01 henrikmidtiby

I would like to handle this PR eventually.

In the meantime, @henrikmidtiby, PR #4115 completely rewrote the Code mobject to make its code much cleaner. We already took care of its typing in that PR, so don't worry about code_mobject.py.

chopan050 avatar Jan 19 '25 18:01 chopan050

I would like to handle this PR eventually.

In the meantime, @henrikmidtiby, PR #4115 completely rewrote the Code mobject to make its code much cleaner. We already took care of its typing in that PR, so don't worry about code_mobject.py. Great! I have rebased the PR on top of the 0.19 branch.

henrikmidtiby avatar Jan 20 '25 21:01 henrikmidtiby