Henning Muszynski

Results 5 comments of Henning Muszynski

I think it's not needed for publishing as `npm publish` runs the `prepare` scripts which generates the assets. I'm not sure about linking reactist it into Twist / Todoist, but...

If I remember correctly it was a line-height problem and setting it to the height of the container fixed it. But my memories are not very clear – with that...

Option 2 sounds good and looks inline with our other components (modal, tabs, etc.), but, as you mentioned, I'd leave this to the one implementing this component. --- Do you...

@gnapse this issue was motivated by work on this (internal) issue: https://github.com/Doist/Issues/issues/7617 – the new alert designs are more lightweight, making me question the usefulness of Notice even more 👍

> Maybe tsdx is using a rollup version older than the one in which a fix for that issue was released According to package-lock, tsdx is using 2.79.1. The fix...