Henk De Groot

Results 49 comments of Henk De Groot

> @henkdegroot not sure if you can help reviewing this PR? Not really comfortable to comment/review this. I can run a test to check if the app still works okay.

@ann0see, looks like the code just concatenates the channelnumber to the name when the option is used. Should the solution be changing the label into two individual labels for this...

> should actually be defined in global.h since they are client, and not OS, Sound.h is in the windows folder for a reason, and believe this is specifically for Windows...

@pljones, do you believe the channel selectors are beneficial to have on others OSs (like Linux)? Would they actually have a purpose there?

> With Jack, you'd be expected to connect correctly using qJackCtl. So we should update the logic to always show the channel selection, except when JACK is used. @pgScorpio, you...

I have done some testing and looks like we should improve the "spacing" in the input/output selection section: ![image](https://user-images.githubusercontent.com/13550012/152684579-607a839c-9465-40a1-8582-1c4c1d690370.png) As you can see in my screenshot, the important part (using...

> Where does this "Default" come from?? I have not modified any code, just made sure the input/output selections are always shown and that is how Jack is listed. Guessing...

@pgScorpio seems to me that the linux/sound.h does not contain the function to "override" the 'Default" name defined in soundbase.h. The windows/sound.h and mac/sound.h do have this functionality. Think some...

> I've set something up, but it still needs some investigation Looks nice to me. Guess we need something for the windows installer as well.

FWIW, when I try to install manually on a Win2022 server...then the autokey script which should take care of the installation of jack, does not kick in. Sounds like something...