jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Published 20 hours ago • verified publisher icon jamulussoftware

Windows: Upgrade JACK dependency to 1.9.21

Open ann0see opened this issue 2 years ago • 11 comments

Short description of changes Another maintenance upgrading PR.

CHANGELOG: Windows: Upgraded JACK build to use JACK 1.9.21

Context: Fixes an issue?

No.

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Should be tested.

What is missing until this pull request can be merged?

Test + CI

Checklist

  • [x] I've verified that this Pull Request follows the general code principles
  • [x] I tested my code and it does what I want
  • [x] My code follows the style guide
  • [x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • [x] I've filled all the content above

ann0see avatar Jun 22 '22 18:06 ann0see

Build failed. Not sure what the problem is.

ann0see avatar Jun 22 '22 19:06 ann0see

Culprit seems to be here: https://github.com/jamulussoftware/jamulus/runs/7011426493?check_suite_focus=true#step:7:160

Some wild suggestions:

  • Access denial might stem from the fact the installer still runs when choco expects it to have finished. It seems like the AutoHotkey logic was updated as part of this release. Maybe the installer hangs in a non-finished step.
  • Access denial might be from Windows Defender (?)

Logs will probably help, not sure if it's worth to spend the effort here now, though?

hoffie avatar Jun 22 '22 20:06 hoffie

Hmm. Yes. De-tagged. Probably worth focusing on other stuff first.

ann0see avatar Jun 23 '22 05:06 ann0see

FWIW, when I try to install manually on a Win2022 server...then the autokey script which should take care of the installation of jack, does not kick in. Sounds like something is not working as expected. I posted a message on chocolatey. Hope to get a reply.

henkdegroot avatar Jun 23 '22 13:06 henkdegroot

The autohotkey script is not working due to changes in the installer screens. Buttons names are slightly different. I have submitted a PR containing a fix to the repo of the package maintainer. Until fixed, we cannot use 1.9.21.

henkdegroot avatar Jun 24 '22 05:06 henkdegroot

Cool, thanks! Linking the PR here: https://github.com/chtof/chocolatey-packages/pull/73

hoffie avatar Jun 24 '22 08:06 hoffie

Perhaps another (re) run of the action script? Just to confirm the auto install still works? Otherwise it should be good to merge.

henkdegroot avatar Aug 11 '22 19:08 henkdegroot

I don't see a way to trigger a re-run via UI. @ann0see Can you just rebase and push?

hoffie avatar Aug 11 '22 20:08 hoffie

Done

ann0see avatar Aug 12 '22 20:08 ann0see

@henkdegroot Can you validate the installation?

hoffie avatar Aug 12 '22 21:08 hoffie

I downloaded the artifact for Windows JACK and installed on my system. All fine. My system had JACK v1.9.19 installed and Jamulus works correct. Connecting to server and audio transmits correct. Next I upgraded my system to JACK v1.9.21 and all still working fine.

Also when JACK is not running, Jamulus detects it and alerts the user.

I would say all good to go.

henkdegroot avatar Aug 13 '22 08:08 henkdegroot