Hendry Wiranto comments

Results 28 comments of


                                            Hendry Wiranto

New linter: flag unnecessary calls to `Finish` on `gomock.Controller`s in Go 1.14+

Hi, look like the interested user still doesn't move forward with this so I created the linter here https://github.com/hendrywiranto/gomockcontrollerfinish will open a PR soon to integrate it also if you...

Multiplicating two numbers and a duration is not reported

Hi,.. I agree with you that multiplying with a duration means that is a clear number, so maybe reporting none would be preferable

assert/require.Len doesn't print anything if the slice is too long

Hello For the argument ordering, you can enable https://github.com/Antonboom/testifylint via golangci

assert: add option to colorize diffs produced by assert.Equal

Hello @mitioshi any plan to continue your work? Some suggestion: Maybe reverse the red and green color since the green one usually means the good one (expected value) Cheers

README: replace Testify V2 notice with @dolmen's V2 manifesto

> hi! > > maybe it's better not to remove, but (in contradict) notice about v2 manifesto? Yes, I think that's also a good idea. I'm thinking if maintainers want...

README: replace Testify V2 notice with @dolmen's V2 manifesto

Thanks for the answer, I have updated the readme with the manifesto Please tell me if you think there is a better wording for this

README: replace Testify V2 notice with @dolmen's V2 manifesto

thanks for the reminder @Antonboom

README: replace Testify V2 notice with @dolmen's V2 manifesto

Hi @MovieStoreGuy I'm glad to hear that there is still plan for V2! Hope you guys can figure something out while making sure this repo (V1) is still maintained regularly...

assert.EqualExportedValues - panic: reflect.MakeSlice of non-slice type [recovered]

Hi! can you give more explanation about what does this error about? a go.dev example like this would help maintainers understand the issue https://go.dev/play/p/AsRNcxCRdWx

assert.EqualExportedValues - panic: reflect.MakeSlice of non-slice type [recovered]

thank you for the testcase addition @johnfrankmorgan after some digging, I think it's fixed here https://github.com/stretchr/testify/pull/1473 this should be fixed on the next version also this issue is duplicate of...