Miao ZhiCheng comments

Results 150 comments of


                                            Miao ZhiCheng

Symbolic execution tests passing in arguments outside the range of the typed parameter

reproduced #919

uploading file to s3 results in error 104 (connection reset)

Remove immutable state vars from var-name-mixedcase

yes please!

TypeError: Cannot read property 'ignore' of undefined

I hit the same problem today, it is because "node_module" is under the same directory of dapplefile. When you run dapple test, it will try to include node_modules/dapple/test/_fixtures/testenv/empty_package/dappfile, which is...

Truffle version from 5.1.49 to later versions slows down tests significantly

@haltman-at I think 5.1.49 was the last known "good" version for us.

Truffle version from 5.1.49 to later versions slows down tests significantly

@haltman-at I tried again following the reproduce steps. - with truffle 5.1.49, the test took 265.334 seconds. - with truffle 5.1.50, the test took 357.748 seconds.

Truffle version from 5.1.49 to later versions slows down tests significantly

okay, I will test again once it's released

Truffle version from 5.1.49 to later versions slows down tests significantly

the problem persists with `5.1.67`

Truffle version from 5.1.49 to later versions slows down tests significantly

Today I tried with "truffle": "5.2.3", the testing speed still experiences major slow down: https://github.com/superfluid-finance/protocol-monorepo/actions/workflows/ci.yml ![image](https://user-images.githubusercontent.com/186660/110520550-47935180-8117-11eb-8d03-77c12872d6d0.png) ![image](https://user-images.githubusercontent.com/186660/110521214-22eba980-8118-11eb-9596-07c6d6fb77d2.png)

Truffle version from 5.1.49 to later versions slows down tests significantly

BUMP, I think it's quite high priority for us. Otherwise we will have to make the move to some other framework in the long run. We are already under lots...