hellohuanlin
hellohuanlin
@jokerttu is this ready for another review?
Thanks for the videos. I can tell the FPS, but it's hard to tell the bitrate difference. Can you try even lower bitrate compared with even higher bitrate?
I saw a few update emails in the past few days. Feel free to re-request review (you can do so from the top right corner)
@vanlooverenkoen Hi, are you still planning on updating this?
@SamerOrfali22 As explained in your issue, your video link fails to load even with Apple's vanilla video player. So it is not related to this plugin. You may want to...
@moffatman Hi, I just want to double check - the solution is not completed yet right? I checked out your branch and try it on a dummy project, and it...
> Will also need another framework PR to send the text directionality of each selection rect Gotcha, should I checkout both this PR and https://github.com/flutter/flutter/pull/117436 to verify?
I pulled your framework change. But got this issue. Not sure what this is (probably not related to your PR). I will take a closer look after Christmas. ![Screen Shot...
@moffatman looks like NullThrownError is deprecated: https://github.com/flutter/flutter/commit/f5249bcb0a26118cffad7413325ab42cbe6c7c09 You probably wanna rebase. For now I will manually make the change.
> @hellohuanlin Yes, you'll need the framework PR there as well. > > Also, there is a problem going on at the same time, there was a change of a...