hellohuanlin
hellohuanlin
Saw a few updates in my email. Just double check - let me know when it's ready for a second review.
> introspecting the file uniform type identifier, @jmagman which API are you referring to? I found this NSURL API but it's only for local resources. ``` [url getResourceValue:&type forKey: NSURLTypeIdentifierKey...
@stuartmorgan thanks for the insight. I think the "opt-in roll-out" strategy is a good idea. It's lucky that we are able to reverse engineer AVFoundation and spot this "loophole", which...
As discussed offline I think we will skip the file type check. I am still looking into integration tests as suggested.
> Was there any way to add an integration test for this? Could you programmatically tell that video was not playing? @jmagman I looked into this for a few days,...
> ``` > error: -[VideoPlayerUITests testEncryptedVideoStream] : ((frames.count >= 3) is true) failed - Must have at least 3 distinct frames. > ``` > > This failed in CI. Hmmm,...
Update: found some clue. Will put up a PR soon.
@aboyo @LarsFanhouse Hi I got the fix but need to create a m3u8 file for integration test. Could you share how you created your m3u8? I have tried the following...
@LarsFanhouse Thanks for the info. I am not sure how GCP converts the video and what exactly contributes to the inverted aspect ratio. Is it possible for you to convert...
@LarsFanhouse > I don't know either what the conditions are to make a video cause this bug. [My fix](https://github.com/flutter/plugins/pull/6507) is to leverage Apple's `AVPlayerLayer`, which is a blackbox. So unfortunately...