Michael Hellicar

Results 30 comments of Michael Hellicar

Hi @wajihkm—apologies for not getting back to you sooner. The best option would be to change the white background to match the icon color. The icon remains the same, but...

Hi @AdiRishi, could you please update the name to follow our [contributing guidelines on naming](https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md#name)?

> > Hi @AdiRishi, could you please update the name to follow our [contributing guidelines on naming](https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md#name)? > > @hellicarusprime my apologies, I missed that requirement. Updated now đź‘Ť No...

@AdiRishi One other small thing is that the border should be applied to the outside rather than the center. You currently have a 37 x 23 px rectangle with the...

Hi @vponline there is already an HSBC logo available so you don't need to add another one. Please update and I'll review.

@vponline I noticed that the icons you want to add are missing a visible border. Please refer to [this section](https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md#appearance) of our contributing guidelines.

Hi @ryantiptop—could you please add a visible border to the icon? See our [contributing guidelines](https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md#appearance).

Hi @ryantiptop—you're border radius isn't correct. `The border must have a 2px radius`

Hey @ryantiptop, in the example you shared, it looks like you're using an inside stroke.

@jasonatyoco Your SVG doesn't follow the [contributing guidelines](https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md#guidelines-for-new-icons).