payment_icons icon indicating copy to clipboard operation
payment_icons copied to clipboard

Add logos

Open vponline opened this issue 11 months ago • 6 comments

Why are you adding this icons?

I'm adding/updating this icon(s) because ..

Help us identify yourself

  • [x] I'm working/collaborating with the brand directly and they have provided the icons.

Link to the brand guidelines: Volt Design Guidelines

Checklist to add new icons

  • [x] All icons have a corresponding entry in db/payment_icons.yml
  • [x] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • [x] I have optimized the icon with SVGO
  • [x] I am confident that all icons are clear and easy to read/understand
  • [x] I have provided a link to the brand icon’s brand guidelines whenever possible.
  • [x] I have attached a screenshot comparison with the example icon provided in guidelines
  • [x] I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

Attach a screenshot of the icon along side the example Visa icon

image_720

vponline avatar Mar 18 '24 09:03 vponline

Hi @vponline there is already an HSBC logo available so you don't need to add another one. Please update and I'll review.

hellicarusprime avatar Apr 03 '24 12:04 hellicarusprime

@vponline I noticed that the icons you want to add are missing a visible border. Please refer to this section of our contributing guidelines.

hellicarusprime avatar Apr 08 '24 10:04 hellicarusprime

@hellicarusprime fixes have been applied, please check again 🙏

vponline avatar May 16 '24 12:05 vponline

Are there any further changes required to get these accepted please?

vponline avatar Aug 29 '24 08:08 vponline