Christoph Heine

Results 152 comments of Christoph Heine

I see that pillow extended their DDS support which is nice :) Although it is probably still slow. I've added a link to pillow's code to the initial post. We...

@TobiasFP It is not strictly necessary, but using pillow is better than no support. We can implement this issue using pillow and leave it open until the Cython implementation is...

@sandsmark Thanks :) Although for me it's mostly the rapidly increasing number of .dat versions that makes reading the genieutils C++ code and openage converter Python code confusing. I think...

@svyshlov Hey! :) genieutils can only read and write in the .dat format and cannot output readable text. I linked it because the the source code contains a lot of...

@svyshlov You don't need to compile the openage converter for this issue (only a few of the media parsers use Cython for extra speed). Also, the error you encounter is...

It's probably easier to discuss most changes with code that compiles properly, but I already have some comments :)

Additionally, it might be beneficial to use the [profiling utilities](https://github.com/SFTtech/openage/blob/master/openage/util/profiler.py) to compare the speed of the implementation before and after each change.

@9a24f0 Do you need help with completing the PR?

![render-test](https://user-images.githubusercontent.com/6852422/120091471-b3c89480-c10b-11eb-93f7-824e5e891fdd.gif)