Hans-Erik Floryd

Results 11 comments of Hans-Erik Floryd

I'm uploading results from clang scan-build and seeing this also when no issues are detected. As a workaround the report is only uploaded if issues were found however I suspect...

Thanks, that makes sense. Note that I am also using sarif-multitool to convert clang individual files to a merged report. Clang produces one report per analyzed file that looks like...

-fPIC is added automatically by cmake if BUILD_SHARED_LIBS is enabled. Currently of course a static library is always built, so you will also have to remove STATIC from the cmakelist,...

Your use-case seems reasonable but would it not also be sufficient to configure SOEM with -DCMAKE_POSITION_INDEPENDENT_CODE=ON? There are many cmake flags that a user might wish to set and I'm...

Our main use-case is to cross-compile SOEM for other architectures, most of which don't have shared libraries. An easy way to enable shared libraries would be useful but it should...

When state INIT_COMM is entered, the OD is first initialised with the values in od_defaults, then loaded from CO_STORE_COMM. Would it be possible to store the updated values after an...

Regardless of this issue it might be useful to add a callback for LSS changes? In your use-case the COB-ID always follows the node ID, i.e. you can generate them...

In general I think this is fine but was meaning to see if we could add some compile-time check for the unaligned arrays issue. We can document the limitation but...

> In general, what happens if the bitlength of an entry doesn't match its datatype (for integers)? If they need to match, why are both specified? You mean in co_entry_t?...

> > > In general, what happens if the bitlength of an entry doesn't match its datatype (for integers)? If they need to match, why are both specified? > >...