Heejae Chang

Results 464 comments of Heejae Chang

did you see something like this in other output window? like this issue? https://github.com/microsoft/pylance-release/issues/5236 that's usually what should happen when OOM happened. ``` [7640:000002A8D5000000] 106 ms: Scavenge 2.3 (3.0) ->...

see this - https://code.visualstudio.com/docs/csharp/refactoring#_implement-all-members-implicitly there are a few of refactoring of this kind. called `implement interface`, `implement abstract class` and etc.

![image](https://github.com/microsoft/pylance-release/assets/1333179/bf56796b-e4f9-4451-892e-ec8bdb549b46) it does grey them out. I assume you are using `pylance` not `jedi`? if it still repro, can you provide us full logs as described in [the troubleshooting guide](https://github.com/microsoft/pylance-release/blob/main/TROUBLESHOOTING.md#filing-an-issue)?

we should add a test for it to catch regression next time.

this will require some groundwork before doing this work. 1. resolve indexing perf regression we are having (or improve it better than before) 2. support requirements.txt and pyproject.toml to limit...

`1. resolve indexing perf regression we are having (or improve it better than before)` this has been handled by https://github.com/microsoft/pyrx/pull/5007 and https://github.com/microsoft/pyright/pull/7652

closed as a dup. another case where our doc string builder can't handle.

sounds like we need to add `recursion detection` in https://github.com/microsoft/pyrx/blob/main/packages/pyright/packages/pyright-internal/src/analyzer/service.ts#L1128 that said, since `path` has semantic meaning in python, we probably need to detect recursion on each branch like how...

how we will implement or how much perf cost it will have, we need to dig in but before that, we probably want to see how many people will upvote...

I briefly looked, and we get decls for all identifiers (basically names), but we only get the type of the decl, not at each specific position, which will cause us...