Henning Dieterichs

Results 602 comments of Henning Dieterichs

~Unfortunately, I cannot reproduce. Can you look into what causes this?~ I can reproduce on the iPad.

It would be awesome if you could investigate this bug! Here is our guide how to debug the language support of the monaco editor: https://github.com/microsoft/monaco-editor/blob/main/CONTRIBUTING.md#debugging--developing-language-support

Can you provide a minimal sample that runs in the monaco editor playground? It would be awesome if you would file a pull request!

@jogibear9988 can you revert that PR and try if that fixes it? [Here is how you can test it](https://github.com/microsoft/monaco-editor/blob/main/CONTRIBUTING.md#debugging--developing-the-core-editor)

Can you figure out why these changes break the hover in webcomponents? Also, feel free to create a PR that reverts the changes!

Thanks for investigating! @aiday-mar can you look into this?

Related: https://github.com/microsoft/vscode/issues/87274

Thanks for the PR! Unfortunately, I'm not able to understand the PR description. > This foundational change allows for the separation and individual handling of different modalities based on various...

Will look into this next week, this week we have testing!

I had a more detailed review now. Over the years, the `SignalLineFeatureContribution` changed in many (unintended) ways and is not in a good shape anymore. Ideally, a `LineFeature` is stateless,...