Henning Dieterichs

Results 602 comments of Henning Dieterichs

I cannot reproduce. Does this bug still apply?

Can verify that it works in [0.28.1](https://microsoft.github.io/monaco-editor/playground.html?source=v0.28.1#XQAAAAKaCgAAAAAAAABBqQkHQ5Njdzm24qt3LeDjTaoyCh4GLwSGSN7SFXtLpsEaxCli5UIDcYR4oTRLt1wzYaezWR3fJIQiyxnJc4DTbnjMmnzfh6cXzZzPRQz5EjNB2ww78v0LJJGn03IPte0LI9ItsrCuwNzXFuJ5yJZT6aNUcRPpG0ejQtFxC1L73kF5V7QFq__5WsA4lEkaCYSzcXEWP7jI8V7XkOxvqAT3oUYEy7_7h9VmSFToGf_B5a6UrN281ohKIlSxRuBFlAXOf6sYNMWxOdORN04hSmqVYf1DSpHKU_-FO_SD4ydE8eFQMAHLxaSFRnbj3CYJ99FO7ohr-rof_pGGmIbCjGXC8W1tmwD2rvFC7jKVDcy33xwdyuiDgqKe-NJCiQE82NbJdpm4_og1C2bpTtbl3Lndw3Z7OJfDQJVuN1fJWIpVZN-k2iPfxr747t7wRn_jn_CsSgTWfVNIOSsXtVjAFT4PpTN03otTnTkTM2XADSSah9YqncHfAkBjEntvgT13d2QKpMzRnxuoym5r2A-BqFLZaKnukXf6ZOxRnPhqwTs0AtxqXuFz3llFLDR2Uo90eyvB8wqiNItcYT4xXZ1m_mNLGRJPgcCD9JadGFJm6CtBjbWejl7RoaZmqrKzuwmLo1PYKvIzhxE_3T5zwxVwEMECSO_WACbc-NzrDpcRNxoYYdnzwhngd7U7D3zd6PoWy5BvOaeuuVAusVGm2-28M3qngv2MSxD7zbpt873N-DiDvv2RtJDSN8LhaMcqtm_gJo5_RaH2fuvVjuUTFnqwCIgG-XxKrySHM5umJkHVVWHi_k5dzQEfzdMmGi1DhOe0svNIKqbjx7RpdOqmwThXDOWdQOm9nqbi4TxHye0vdDfIW0r2iDRWVWXRA6-0WIxECNWpRTjHpDi0sqeul1T_rU52pw) but breaks in [0.29.0](https://microsoft.github.io/monaco-editor/playground.html?source=v0.29.0#XQAAAAKaCgAAAAAAAABBqQkHQ5Njdzm24qt3LeDjTaoyCh4GLwSGSN7SFXtLpsEaxCli5UIDcYR4oTRLt1wzYaezWR3fJIQiyxnJc4DTbnjMmnzfh6cXzZzPRQz5EjNB2ww78v0LJJGn03IPte0LI9ItsrCuwNzXFuJ5yJZT6aNUcRPpG0ejQtFxC1L73kF5V7QFq__5WsA4lEkaCYSzcXEWP7jI8V7XkOxvqAT3oUYEy7_7h9VmSFToGf_B5a6UrN281ohKIlSxRuBFlAXOf6sYNMWxOdORN04hSmqVYf1DSpHKU_-FO_SD4ydE8eFQMAHLxaSFRnbj3CYJ99FO7ohr-rof_pGGmIbCjGXC8W1tmwD2rvFC7jKVDcy33xwdyuiDgqKe-NJCiQE82NbJdpm4_og1C2bpTtbl3Lndw3Z7OJfDQJVuN1fJWIpVZN-k2iPfxr747t7wRn_jn_CsSgTWfVNIOSsXtVjAFT4PpTN03otTnTkTM2XADSSah9YqncHfAkBjEntvgT13d2QKpMzRnxuoym5r2A-BqFLZaKnukXf6ZOxRnPhqwTs0AtxqXuFz3llFLDR2Uo90eyvB8wqiNItcYT4xXZ1m_mNLGRJPgcCD9JadGFJm6CtBjbWejl7RoaZmqrKzuwmLo1PYKvIzhxE_3T5zwxVwEMECSO_WACbc-NzrDpcRNxoYYdnzwhngd7U7D3zd6PoWy5BvOaeuuVAusVGm2-28M3qngv2MSxD7zbpt873N-DiDvv2RtJDSN8LhaMcqtm_gJo5_RaH2fuvVjuUTFnqwCIgG-XxKrySHM5umJkHVVWHi_k5dzQEfzdMmGi1DhOe0svNIKqbjx7RpdOqmwThXDOWdQOm9nqbi4TxHye0vdDfIW0r2iDRWVWXRA6-0WIxECNWpRTjHpDi0sqeul1T_rU52pw).

Interesting problem. Unsure how a clean implementation/ux would look like though. Maybe decorations can be used to indicate ranges that should be excluded for wrapping. But what if some users...

Can you file this as feature request for VS Code? That could make it more likely to get it implemented.

I'm not sure if this is easy to fix - I guess the typescript compiler ships various libraries (like ES3/ES6).

This is because json uses its own tokenizer. It works for [typescript](https://microsoft.github.io/monaco-editor/playground.html?source=v0.44.0#XQAAAAJ8AQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscwzixTe_1uhs0-3YGTBOsVJ4S4FwfCDQb5-2uUHXTVAefbVSd9IzaZ_vv9VR9KugsKiuHAg9KQ6ZwEgg65_cAgZ7FYyNxeWYeKJhXGybBciKNlw9ELqlBdRNuEPSOngtd6dqtVNLqa0EuxxQ1PhjzZZov6QtUdyLB9SvyxzAt76Nyz62IK5-0LgJgvf4AuKAyuKUYenYR6ykX5-IqPT3eQme3JRmabWNZkRvc3j-OeHVz-byInLC9XTH7Ym276tM9F6XxmxJObH2UvAs2-HuksYsiXcANVd4kfqy854CfFsFJ2kp9hOUeQpd4YyX1YGxXG6cEzJEj_FGw8AA)

I believe this is fixed in newer versions of typescript.

@aiday-mar can you look into this? It works in https://microsoft.github.io/monaco-editor/playground.html?source=v0.35.0-dev.20230126#example-extending-language-services-model-markers-example - you can use the bisect feature of the playground to identify when it broke.

Thanks for the PR! And sorry for the delay.