Henning Dieterichs

Results 602 comments of Henning Dieterichs

I think a first implementation could just cover the case when `override` is present to avoid various problems. A simple reference implementation could be this: Whenever this pattern matches syntactically:...

@alexdima can we set this as default for js?

I can also confirm the bug. I'll try to look into this next milestone, but you would help us a lot with a pull request if you can find the...

You can find the unminified code [here](https://github.com/microsoft/vscode/blob/hediet/fix-inline-completion-tests/src/vs/editor/browser/widget/diffReview.ts#L837). I guess the question is why `t.getActiveCodeEditor` returns null.

This is what I see: https://microsoft.github.io/monaco-editor/playground.html?source=v0.36.1#XQAAAAKXAgAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw2FYXdHDtEDhQ6OU4assJFdYGava4wpdXLFRLNLFqJ8YUtwIBhVXikQrWprFr6cU-K_xWN6UbjDoeIlxIlkQ0ZXycT4SGEz5R8_2mcPFRNmcdINTgDBDZCurcSPvcrEKOeozp2Xu1an2K4_KBGPZppNGRkMtOGAHi4T2K8S4aMrySkivJjMyAid18k8J3sEmabdZBUy7768q2SKHRQ8pAgJqcBrtW2DRHDvMbOTerpCwrFH1UeJmOBDzJ9LYLOcQFUxYgyDbqQL73c3AA8IW3HpJJHO-BTvvh1cBF-T6sfQ8o7juEb2-VZd7qkOS6M020G2AQ0HCFj1gnA1h2Wyh5jLa-Hc0Hnxr-U7nMxpVoIZzpMOqMaEMKHORqiKVpLwVP6j5DKagtRvb-aM2eU6R79Yx-JHcDRNIL_Jj_5MY3Wg ![image](https://user-images.githubusercontent.com/2931520/224743124-781e36d5-07d0-4d37-bc21-0e6e45b5f2a3.png) Notice how the context menu does not seem to be styled.

Possibly a duplicate of https://github.com/MicrosoftDocs/live-share/issues/4601 . This is a serious bug!

Probably this array needs to be extended: https://github.com/hediet/vscode-debug-visualizer/blob/1b6fabfe29415f65732c96e043f67f6d341631e6/extension/src/VisualizationBackend/PyVisualizationSupport.ts#L34-L36

I fear using this extension with lldb might be difficult. Your expression has to evaluate to a JSON string. You can use the debug console to figure out what the...

This looks really bad. @deepak1556 do you remember which commits you merged (against which base commit) that caused this?

@benibenj also noted that it is difficult to find the approve button. > I still like and prefer the dropdown for reducing UI complexity. I agree that it reduces UI...