Show All Buttons Comment/Request Changes/Approve when there is enough space

[hediet]

Currently it looks like this:

I think it would be nice if it looked like this when there is enough horizontal space:

I think I lose some mental energy when I want to approve, but I have to first click on the drop down of "Request changes".

[alexr00]

@hbons in case you also have thoughts on this!

[alexr00]

It's a bit funny because I actually just removed these in the full sized view: https://github.com/microsoft/vscode-pull-request-github/issues/5334

[alexr00]

@bpasero you recently requested that I move the three buttons into the dropdown menu in the full editor webview in https://github.com/microsoft/vscode-pull-request-github/issues/5334. Now, I've gotten the request to expand the dropdown out into 3 buttons when space permits in the sidebar webview. If I make this change in the sidebar, I would also move the 3 options back into 3 buttons in the editor webview, since space always permits there. Do you have any opinion on this?

[bpasero]

I still like and prefer the dropdown for reducing UI complexity.

[hediet]

@benibenj also noted that it is difficult to find the approve button.

I still like and prefer the dropdown for reducing UI complexity.

I agree that it reduces UI complexity, but I would argue that this comes at the cost of increased mental complexity. "Approve" and "Request Changes" are not suboptions of "Comment", they are primary actions with opposite effects.

Especially when "Request Changes" is pre-selected, it causes mental resistance to click on its drop-down to select "Accept", as they have opposite effects, end the effects are quite severe.

[benibenj]

I don't find the "Active PR View" helpful in general, so I never use it. And so when I have to approve a PR I don't remember where the button is. It always takes me a while until I see the drop down. For my case I would prefer a different entry point to approve a PR. For example when I have marked all files as viewed there could be a notification similar to the create PR notification (I use this all the time). I also think multi diff editor (maybe also PR tree) could include actions to approve the PR.

[alexr00]

For example when I have marked all files as viewed there could be a notification similar to the create PR notification (I use this all the time).

Very interesting idea. We can definitely have this.

[alexr00]

To verify:

• Install the pre-release version of GitHub Pull Requests.
• Open a folder that contains a GitHub repository and some pull requests.
• Check out a pull request that isn't yours
• Open the active pull request view (this is the webview in the sidebar) and drag it larger and smaller. Verify that when it's "small" you get one button with the drop down caret for completing your review. Verify that when it's "big enough" you get all three buttons in a row (comment, approve, request changes).