Hennadii Stepanov
Hennadii Stepanov
Clang >=15 still might need linking against `libatomic`. We use `std::atomic::compare_exchange_strong` in `net_processing.cpp`. Addresses the https://github.com/bitcoin/bitcoin/pull/29165#discussion_r1440293694.
The current LTO functionality implementation has multiple issues: 1. Duplicated `-flto` flags when linking. 2. The `secp256k1` subtree code is built without LTO. 3. In `AX_CHECK_LINK_FLAG` macro the wrong `CXXFLAG_WERROR`...
This PR reduces false warnings, especially for unit tests. From the Boost.Test's [point of view](https://github.com/boostorg/test/blob/d2895ebfdfdf16074c58c9801d53e190c4654fcb/include/boost/test/unit_test.hpp#L11), the `boost/test/unit_test.hpp` header: ``` ... should be the only header necessary to include to start...
See https://github.com/include-what-you-use/include-what-you-use/pull/1026. Split from https://github.com/bitcoin/bitcoin/pull/27710 as a non-controversial change.
This PR enables AVX2, SSE4.1 and x86 SHA-NI implementations of SHA256 instead of the "standard" one. **NOTE about testing**. During runtime the SHA-NI implementation is available only if a CPU...
This PR is a revived https://github.com/bitcoin/bitcoin/pull/27991 with an addressed [comment](https://github.com/bitcoin/bitcoin/pull/27991#discussion_r1252148488). Fixes https://github.com/bitcoin/bitcoin/issues/27990. Might be tested as follows: ``` $ ./autogen.sh && ./configure --enable-fuzz --with-sanitizers=fuzzer CC=clang-13 CXX=clang++-13 $ make clean >...
This issue will be updated to reflect the current state of CMake integration. A brief historical context: 1. https://github.com/bitcoin/bitcoin/pull/25797 proposed a CMake-based build system with 100% feature parity to the...
Having an intermittent error in my local Windows: ``` > py -3 test\functional\test_runner.py --jobs 40 --timeout-factor=8 ... 165/269 - feature_versionbits_warning.py failed, Duration: 59 s stdout: 2023-09-25T11:29:08.904000Z TestFramework (INFO): PRNG seed...
For example, in the native macOS CI job, the `LD_LIBRARY_PATH=/Users/runner/work/bitcoin/bitcoin/depends/x86_64-apple-darwin/lib` makes no sense.
Closes https://github.com/bitcoin/bitcoin/issues/24907. This PR is based on **theStack**'s [work](https://github.com/bitcoin/bitcoin/issues/24907#issuecomment-1466087049). I've fixed Windows-related bugs and issues and commenced submitting patches to [upstream](https://github.com/arun11299/cpp-subprocess). For more details, please refer to commit messages.