Hennadii Stepanov

refactor: Use move semantics instead of custom swap functions

9

This PR makes code more succinct and readable by using move semantics.

refactor: Make `CCheckQueue` RAII-styled

6

https://github.com/bitcoin/bitcoin/pull/18731 revived. Fixes https://github.com/bitcoin/bitcoin/issues/25448.

`security-check.py` produces false positive result for stack smashing protection

4

I'm aware that `test-security-check.py` tests both cases `-fno-stack-protector` and `-fstack-protector-all`. However, the `security-check.py` passes in the master branch @ 986047170892c9482ccbc21f05bf4f1499b3089d with the diff as follows: ```diff --- a/configure.ac +++ b/configure.ac...

Release `LockData::dd_mutex` before calling `*_detected` functions

8

Both `double_lock_detected()` and `potential_deadlock_detected()` functions call `LogPrintf()` which in turn implies locking of the `Logger::m_cs` mutex. To avoid a deadlock, the latter must not have the `Mutex` type (see https://github.com/bitcoin/bitcoin/pull/16112)....

Unnecessary symbols being exported in `libbitcoinconsensus.so`

10

Initially it was reported in https://github.com/bitcoin/bitcoin/pull/25020#issuecomment-1142151675. ``` $ objdump -T ./bitcoin-24.0.1/lib/libbitcoinconsensus.so | grep bitcoinconsensus_ 000000000002b1f0 g DF .text 0000000000000037 Base bitcoinconsensus_version 000000000002cc30 g DF .text 000000000000006d Base bitcoinconsensus_verify_script 000000000002cbe0 g...

`./configure` fails for clang-14 on Ubuntu 23.10

5

``` $ clang-14 -v Ubuntu clang version 14.0.6 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/13 Selected GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/13 Candidate multilib: .;@m64 Selected multilib: .;@m64...

Add 1-way SSE4 SHA256 implementation using intrinsics for MSVC builds

2

This PR reintroduces the 1-way SSE4 SHA256 implementation using intrinsics, as suggested in https://github.com/bitcoin/bitcoin/pull/13442, specifically for MSVC builds, where a 50% performance gain has been achieved. Here are benchmarks on...

Fix SSE4.1-related issues

8

1. Fix the test for SSE4.1 intrinsics during build system configuration, which currently can be false positive, for example, when `CXXFLAGS="-mno-sse4.1"` provided. This PR fixes the test by adding the...

Broken `--enable-suppress-external-warning` for Apple Clang 15 on `x86_64`

2

Apple Clang 15 does not support `-Xclang -internal-isystem` anymore. On both `x86_64` and `arm64` platforms, the following check: https://github.com/bitcoin/bitcoin/blob/65c05db660b2ca1d0076b0d8573a6760b3228068/configure.ac#L742-L744 fails with `error: unknown argument: '-internal-isystem/usr/local/include'`. It makes the `--enable-suppress-external-warnings` option...