Hennadii Stepanov

qa: Fix `wallet_multiwallet.py`

2

Fixes https://github.com/bitcoin/bitcoin/issues/31409. The first commit prevents possible false positives by ensuring that each condition potentially causing the "Error scanning" log message is tested separately. The second commit disables a problematic...

cmake: Fix passing `APPEND_*FLAGS` to `secp256k1` subtree

9

On the master branch @ 70e20ea024ce4f39abc4022e1ba19d5a6db2a207, the `APPEND_CPPFLAGS`, `APPEND_CFLAGS` and `APPEND_LDFLAGS` are not correctly applied when building C code in the `secp256k1` subtree, as intended. This behaviour occurs due to...

cmake: Support user-defined C++ standard

2

This PR introduces a native CMake's way to test newer C++ standards. Also see: https://github.com/bitcoin/bitcoin/pull/30735. To configure builds with newer standards, run: ``` $ cmake -B build -DCMAKE_CXX_STANDARD=23 # or...

cmake: Improve robustness and usability

2

This PR: 1. Switches to a modern CMake approach by using the `Python3::Interpreter` imported target, which is more robust than using variables. 2. Disables tests instead of ignoring them. For...

cmake: Improve compatibility with Python version managers

3

This PR resolves the issue [highlighted](https://github.com/bitcoin/bitcoin/pull/31411#issuecomment-2516745547) in https://github.com/bitcoin/bitcoin/pull/31411: > Here's another case where CMake just picks some other Python... The fix leverages two [hints](https://cmake.org/cmake/help/latest/module/FindPython3.html#hints) for the CMake `FindPython3` module: 1....

[POC] cmake: Introduce LLVM's Source-based Code Coverage reports

3

The `gcov`-based code coverage does not work with Clang (please refer to https://github.com/bitcoin/bitcoin/issues/31047 for more details). This PR employs the LLVM's [Source-based Code Coverage](https://clang.llvm.org/docs/SourceBasedCodeCoverage.html). Here are some examples of usage:...

depends: Avoid hardcoding `host_prefix` in toolchain file

6

This PR allows the entire `depends/` directory to be relocatable. Only `libevent` package configuration files are non-relocatable for the version `2.1.12-stable` we use now. However, this issue has been fixed...

depends: Avoid using helper variables in toolchain file

1

Using helper variables has two issues: 1. They contaminate the global namespace of the main build script. 2. They can be used as `set(var)`, effectively [exposing](https://cmake.org/cmake/help/latest/command/set.html) a cache variable `var`,...

refactor: Fix "modernize-use-starts-ends-with" clang-tidy warning

3

This PR is a follow-up to #31306 and fixes the "modernize-use-starts-ends-with" warning in the multiprocess code (see https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2527008761). Fixes https://github.com/chaincodelabs/libmultiprocess/issues/124.

[POC] build: Use clang-cl to build on Windows natively

9

\< _to be added_ \> Closes https://github.com/bitcoin/bitcoin/issues/31456. Based on https://github.com/bitcoin-core/secp256k1/pull/1647 (the CI lint job failure is expected) and https://github.com/bitcoin/bitcoin/pull/31503. TODO: the build system is configured without `-DWERROR=ON` at this mooment.