Alexander S.
Alexander S.
Which breaks the app and `BaseController` from the gem is never loaded. Should be required explicitly in the gem. Thus my final `BaseController` looks like this: ```ruby class Ahoy::BaseController <...
@ankane this sounds like a good option. I'll try preparing a pull request, perhaps over the weekend.
Doesn't work for me on Ruby 2.6.6 and Rails 6.1. ``` rake aborted! Don't know how to build task 'routes' (See the list of available tasks with `rake --tasks`) /Users/heaven/.rvm/gems/ruby-2.6.6@lively-letters/bin/ruby_executable_hooks:22:in...
That's not a patch, it overrides the entire library (what it shouldn't). I was looking over the changes and it is not possible to say what's namely changed to fix...
Oops, forgot, the first line in `removeLoading` should be changed from `this.$loading.remove();` to `this.$loading && this.$loading.remove();`.
Actually, because there is `callback = callback || function() {};` you can simply call callback without checking if it exists.
This is what I ended up with: ``` javascript } else if (this.isLoading && this.$loading) { this.$loading.removeClass('in'); var that = this; $.support.transition && this.$element.hasClass('fade') ? this.$loading.one($.support.transition.end, function() { that.removeLoading(); callback(that.isLoading);...
Hi, would it be easier for you to simply apply these few lines? I really have no time to work on this right now. Otherwise I can do it tomorrow....
Hi @ParthivSavani, I was mentioning this setting `per_page = [10, 30, 50, 100]`