bootstrap-modal icon indicating copy to clipboard operation
bootstrap-modal copied to clipboard

loading-mask in not always properly removed on hide

Open heaven opened this issue 12 years ago • 1 comments

Hi, it's me again ;)

In hide, there is this.isLoading && this.loading(); which does not work properly and leave div.loading-mask in popup, over the content.

This could be easily fixed by simply adding z-index: 1 to the div.modal-body, but that's not too good since the number of these orphaned divs grows.

This could be fixed by replacing this: this.isLoading && this.loading(); by this.removeLoading();. No reason to call this.loading() since animation is not visible anyway because the modal is being hidden faster.

Another way (seems to be also working) is to move all after this.isLoading && this.loading(); to a callback and pass it to the loading() function.

Example: screenshot 569

heaven avatar Aug 17 '13 19:08 heaven

Oops, forgot, the first line in removeLoading should be changed from this.$loading.remove(); to this.$loading && this.$loading.remove();.

heaven avatar Aug 17 '13 19:08 heaven