Heath Stewart

Results 419 comments of Heath Stewart

@mikekistler @johanste I don't remember who is supposed to approve suppressions. Is anyone on the REST API board? Not sure about the other blocking issue mentioned in "sign off requirements"....

Please note, though: I'm not advocating for using OSC 8 anywhere you render URLs, even though listing runs completely truncates the URLs to be unusable. You already use Glamour to...

You already use glamour to render markdown: https://github.com/cli/go-gh/blob/61bf393cf4aeea6d00a6251390f5f67f5b67e727/pkg/markdown/markdown.go#L67 My point is that, right now with the older glamour you're already using, links split across lines are broken: https://github.com/user-attachments/assets/f85a0212-e919-4e57-9dfc-8e41561d2a9f Notice how...

For methods like `DELETE` which return no response body, an `accept` header isn't necessary. We removed these from our generated client code but are seeing `reqwest` put them back into...

FWIW, I opened it here because my assumption was that `cargo` was not "flatting" the package manifest (if it even does that) before lint tables were parsed. Certainly possible this...

> Hm, unfortunately I'm not able to reproduce that. Can you include a `.zip` file of a workspace the demonstrates the issue? @ehuss certainly, but it'll take me a bit....

It took me a bit - I couldn't repro it either at first - but then I figured out what my minimal repro was missing: an empty `[workspace.lints]` section in...

Clone the repo and run `cargo clippy` from the root. You'll get a `clippy::useless_format` for `deps/foo` warning despite that crate's workspace (`deps/Cargo.toml`) allowing it. If you add the allow to...

> * Is it the outermost? > * Is it the innermost? > * Is this just against the rules? If we're discussing possible design, I'd prefer the innermost since...

Why a new bicep type i.e., `OptionalResource`? Seems this makes the bicep (or ARM) templates less portable. Callers shouldn't *need* `azd` for deployment. This prevents creation through other, existing means...