Heath Stewart

Results 419 comments of Heath Stewart

You can't put a condition anywhere. Service installation has limited control, and Windows Installer does not simply allow using whatever state a resource is in. It is, effectively, a machine...

Could you simply remove the daemon if you're not going to use it and keep the client? ```cmd msiexec /i {path to msi} REMOVE=Server ``` This won't install the service...

Yes, that is technically possible. Either service could be moved to separate features or, if the agent service is required, can be left under `SERVER`. Some new feature e.g., `AUTHSERVER`,...

Thank you for incidentally reminding me: the ssh_agent.exe is already a shared component of both `CLIENT` and `SERVER`, so my original recommendation stands: just remove the `SERVER` feature per the...

In that case, the agent should probably be it's own feature. It can install by default, but could be removed or not installed initially. We should talk with @SteveL-MSFT. I've...

@ismael-ms if possible, can you please avoid rebasing and force-pushing. It makes it very difficult to simply view the changes since last we reviewed, thus having to review the entire...

What matters is that there are no breaking changes between GA versions under the specification/ folder. So if you're removing a path - even in the dev/ folder (same would...

I don't think we need new flags: if someone specifies both `--package` with the package name(s?) to which they want the dependency added and `--manifest-path` pointing to the workspace, if...

> I agree about not having a new flag for this. There is a UX and maintenance cost to any flag or config we add. I think we can go...

Sorry. I did skim through the comments but obviously missed that one. That said, thoughts about whether there's a mix and for any `/.*dpenendencies/` section? I can imagine a case...