Helene Durand

Results 31 comments of Helene Durand

nope, I moved it to KKP 2.22.

Reason for double encoding is: https://github.com/kubermatic/kubermatic/blob/11216c095ca55db6829e43f8ff180ed67d3f630b/pkg/provider/kubernetes/credentials.go#L143 When using the `.Data` field of the secret, the value will be base64 encoded in the Secret. But in the tests, we call it...

The reason is here: (https://github.com/kubermatic/kubermatic/blob/11216c095ca55db6829e43f8ff180ed67d3f630b/pkg/provider/kubernetes/credentials.go#L143) We put in the `.Data` an already encoded value -> it gets double encoded. The previous encoding is done: https://github.com/kubermatic/kubermatic/blob/11216c095ca55db6829e43f8ff180ed67d3f630b/cmd/conformance-tester/pkg/scenarios/kubevirt.go#L70 where we encode the kubeconfig...

I confirm that on live code (not e2e tests): kubeconfig is not base64 encoded when we create a cluster. in pkg/provider/kubernetes/credentials.go ` spec := cluster.Spec.Cloud.Kubevirt` ``` 2022-08-18T11:06:52.103+0200 error kubernetes/credentials.go:448 HELENE2...

The place where it's decoded to a clear value: https://github.com/kubermatic/kubermatic/blob/master/pkg/provider/cloud/kubevirt/provider.go#L81 This is wrong, we should not mutate a field in a `Validate`