Harry Doan

Cannot access the documentation.

1

It's said "Page missing"

Weird wrong calculation for certain date, when start > end date

2

``` const workdays1 = moment().weekdayCalc('21 Feb 2016', '31 Mar 2016', [1,2,3,4,5]); // 29 const workdays2 = moment().weekdayCalc('31 Mar 2016', '21 Feb 2016', [1,2,3,4,5]); // 28 ``` There is a bizarre...

`InheritedResource::Base` [inherits from](https://github.com/activeadmin/inherited_resources/blob/a863c1b58019f63e0ecf34960d4fe4737fc94bfb/app/controllers/inherited_resources/base.rb#L11) `::ApplicationController` and that's the source of a lot of issues for us during development. (We use it with ActiveAdmin). ApplicationController can be touched by many people and...

Create LICENSE

2

It'd be great to have a LICENSE file attached with the project to tell us in what way we can use the source code in the repo. I propose to...

Set up spec for the rbi

2

There should be a way to test the rbi so that reviewing PR is easier. I expect it would be: - Set up sorbet in this repo - Set up...

Use HashWithIndifferentAccess for enum values

5

Currently `sorbet-rails` uses `T::Hash[T.any(String, Symbol), Integer]` for enum values of a model. This works but the `keys` method would return an array of Symbol or String. Rails actually use HashWithIndifferentAccess,...

Add a debug mode when running rails_rbi:models

1

**Describe the issue:** When running `rails_rbi:models`, if a plugin runs into issue, it is suppressed. See https://github.com/chanzuckerberg/sorbet-rails/blob/master/lib/sorbet-rails/model_rbi_formatter.rb#L128 We should provide a way to run with `allow_failure: false` for debugging. **Expected...

Generate sigs for scope, has_many, etc.

1

It is not possible to generate the sigs right now because T.proc support is limited right now. For example: It doesn't work with generic https://github.com/sorbet/sorbet/issues/1139 It doesn't work with variable...

**Describe the bug:** We can improve the code for finding out the assignable type for attribute writter. See #223 **Steps to reproduce:** **Expected behavior:** **Versions:** - Ruby: - Rails: -...

Rails 5 add a new API that let users define a custom type for attributes in a model. Currently Sorbet-rails read the attribute type from the database definition. Learn more...