Mitch Phillips

> > has inadequate XSRF protection > > SB++ absolutely don't have CSRF protection. I was under impression that the `if (!defined("IN_SB"))` early exit conditions were an attempted weak form...

@smithp35 @MaskRay @pcc @eugenis @fmayer @enh This is related to https://reviews.llvm.org/D128958.

Not hugely familiar with Github's review process - whether inline comments are published on-demand or only on this comment is unclear to me. I've addressed the outstanding reviewer comments, leaving...

> @hctim could you add this document to > > * tools/common/check-rst-syntax.sh > * tools/rst2pdf/generate-pdfs.sh > * toplevel README.md > > Adding the document to `generate-pdfs.sh` will have the added...

> We're working through the process at the moment, I think the major things we need are: > > * The copyright according to the recently updated CONTRIBUTION guide. I...

> I've given this my approval. What I suggest is to leave this open till next week for any further comments/objections. Once that has been covered the changes can be...

> Thanks for the update. It looks like the only option I have is Rebase and Merge. If you are able to squash the commits using your suggest commit message...