hccheng72 comments

Repositories
Issues
Comments

Results 2 comments of


                                            hccheng72

[V2] DriverV2 should use AzDiskDriverConfiguration instead of duplicating config fields

/assign

[V2] bug: WaitForAttach call should also be able to detach replicas for primary

Can we move [creating attachmentObj](https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/354043cc23ab44baa242a9af406933f058ebd0db/pkg/provisioner/crdprovisioner.go#L563) right after attachmentObj isn't found? So if the creation fails, the function can return early and save `getReplicasToDetach` process. Same idea for: https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/354043cc23ab44baa242a9af406933f058ebd0db/pkg/provisioner/crdprovisioner.go#L587 https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/354043cc23ab44baa242a9af406933f058ebd0db/pkg/provisioner/crdprovisioner.go#L623 can...