Hwee-Boon Yar
Hwee-Boon Yar
@oa-s what else is left for this PR?
@oa-s OK, I'll check the next 2 days. Working on something at the moment. Can you help paste a permalink to show where to look (if you know already)?
Getting a warning after I rebase master (not pushed here): > [R.swift] project.pbxproj is internally inconsistent. Probably a bad merge with the project file
Pushed 2 commits that fixes the project file. They can be squashed into your commit(s)
Just notes: Sent an EIP-1559 transaction on Goerli https://goerli.etherscan.io/tx/0x6fbe4f273f7c0ef419e8e86ca7f3c6e5d38f85bbe06cb5a4dd7a1fb03bbdcaab Was successful and gas price = 284.x gwei, much higher than a transaction from 2 days ago https://goerli.etherscan.io/tx/0x598d15adc5cd894ab82b2c42cfca2516d1f39a365cea1110c83bf2e2dc4ba9b1 But seems inline...
- [ ] Looks like `TransactionConfigurator` isn't destroyed after `TransactionConfirmationCoordinator` is destroyed by cancelling the transaction confirmation actionsheet - [ ] With EIP-1559 transactions, we still need the old "Gas...
> What about estimates, do they seem correct? Sometimes i was able to catch zero estimates, on mainnet. Looks like that happened because of zero base fee. Not sure on...
Already in 0a414d4dc37486563615195ae4430010327e5634
Had problem with LSP definition as well as references. Suggested fix by @teocns works for me. Thanks.
Commented at https://github.com/AlphaWallet/alpha-wallet-ios/issues/2793. Likely no design work needed from Tomek for iOS.