EIP1559 implementation #4138

[oa-s]

Closes #4138

[oa-s]

@hboon need your help to check if function EIP1559FeeOracle.eip1559FeeEstimates() works as needed.

[hboon]

@oa-s you need to push your web3swift fork.

[oa-s]

Do we check or hardcode if a chain supports EIP1559?

nope, in case chain when doesnt support EIP1559 the fee history request will return an error

[oa-s]

continue after https://github.com/AlphaWallet/alpha-wallet-ios/pull/5246

[hboon]

@oa-s don't forget this

[hboon]

@oa-s should finish up this

[oa-s]

should finish up this

here we got an issue with calculating estimate values, have no idea how to fix it

[hboon]

Would you help rebase and point out where it is? Can help to see too, if you like

[oa-s]

Would you help rebase and point out where it is? Can help to see too, if you like

yes, sure

[oa-s]

@hboon bump

[hboon]

@oa-s ah. Should I look at any particular place?

[hboon]

@oa-s okie, I'll take a look. Thanks!

[oa-s]

@hboon any success with this issue?

[hboon]

@oa-s sorry, stuck with some other work, will come back to this :)

[oa-s]

@hboon i will push after rebase, fixed signing tx, and some other issues, still have issue with estimation coputation

[hboon]

@oa-s thanks. Sorry, haven't come to look at this yet. I will, but I will let you know before I do in case you work on this.

[oa-s]

@oa-s thanks. Sorry, haven't come to look at this yet. I will, but I will let you know before I do in case you work on this.

yes, sure

[hboon]

@oa-s what else is left for this PR?

[oa-s]

tweak changing fees when sending a tx

[oa-s]

• handling fees updates

[oa-s]

@hboon could u please take a look at editing gas fee, not quite sure how to done it

[hboon]

@oa-s OK, I'll check the next 2 days. Working on something at the moment. Can you help paste a permalink to show where to look (if you know already)?

[oa-s]

@oa-s OK, I'll check the next 2 days. Working on something at the moment. Can you help paste a permalink to show where to look (if you know already)?

sure, will do

[hboon]

Getting a warning after I rebase master (not pushed here):

[R.swift] project.pbxproj is internally inconsistent.

Probably a bad merge with the project file

[hboon]

Pushed 2 commits that fixes the project file. They can be squashed into your commit(s)

[hboon]

Just notes:

Sent an EIP-1559 transaction on Goerli https://goerli.etherscan.io/tx/0x6fbe4f273f7c0ef419e8e86ca7f3c6e5d38f85bbe06cb5a4dd7a1fb03bbdcaab

Was successful and gas price = 284.x gwei, much higher than a transaction from 2 days ago https://goerli.etherscan.io/tx/0x598d15adc5cd894ab82b2c42cfca2516d1f39a365cea1110c83bf2e2dc4ba9b1

But seems inline with a transaction around the same period (281 gwei) https://goerli.etherscan.io/tx/0xe17bb1df31f254db3d1336dd5312ebfc5b49b8b1160852330498610b99507099

[oa-s]

I am finishing with applying updates to ui, will test it more, and we will be able to finish it

[oa-s]

What about estimates, do they seem correct? Sometimes i was able to catch zero estimates, on mainnet. Looks like that happened because of zero base fee. Not sure on what step it setted to zero

[hboon]

• [ ] Looks like TransactionConfigurator isn't destroyed after TransactionConfirmationCoordinator is destroyed by cancelling the transaction confirmation actionsheet

• [ ] With EIP-1559 transactions, we still need the old "Gas Limit". So 2 sliders for pre-EIP-1559 and 3 sliders for EIP-1559

[hboon]

What about estimates, do they seem correct? Sometimes i was able to catch zero estimates, on mainnet. Looks like that happened because of zero base fee. Not sure on what step it setted to zero

I'll play with it a bit more and look at the estimation function. No idea how it's supposed to work, but I'll check