Alex Zaytsev

Results 368 comments of Alex Zaytsev

> Or leave it as is? I don't know.

@fredericDelaporte what about changes as in e8c8a3b07e3a06c545c7bdf43472877220a04927 (minus null check)?

@fredericDelaporte @gliljas please check. This change is consistent with how some other types handle parameters, for example: https://github.com/nhibernate/nhibernate-core/blob/7f60bc3a875a721d6ad4b76b530f2447da79454f/src/NHibernate/Type/Int32Type.cs#L59-L62

Rebased and dropped all other commits.

Reverted the 'fix' as I'm trying to understand what we are fixing here.

Ok, this was dragging for a long time. We need to decide what to do. Just for context enum might not have a name (!) and [`Enum.GetName(...)`](https://learn.microsoft.com/en-us/dotnet/api/system.enum.getname) will return `null`....

PS: should have re-read the whole thread before posting my reply :-(

> **Switch for service provider but leave functionality as-is** I'm not sure what exactly this switch is going to achieve, can you elaborate? It is super easy to wrap `IServiceProvider`...

I think the solution would be to throw `PlatformNotSupportedException` on access to WebSessionContext. Thoughts?

I don't think we would be able to find a viable solution at the moment.