Alexander L. Hayes
Alexander L. Hayes
> Would you be up for trying to implement it? If you can assign me to this issue I can schedule some time! It probably won't be for a few...
That worked, really helpful explanation as well. Thank you! Would you like for something like this to be contributed to the *Examples* documentation?
Duplicate of #89, and fixed in #90 Upgrading should resolve this.
My mistake, the patch might not have been released on PyPi yet. It should be on the master branch: ```bash git clone [email protected]:SPFlow/SPFlow.git cd SPFlow/src/ pip install -e . ```
@faroit Sure, looks interesting!
## Review checklist for @hayesall ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...
Thank you for your patience. I've opened some issues/PRs with recommendations. I'd definitely like to see these points addressed: - https://github.com/xinyiguan/py2lispIDyOM/issues/12 - https://github.com/xinyiguan/py2lispIDyOM/issues/9 - https://github.com/xinyiguan/py2lispIDyOM/pull/11 If the first two items...
Happy to help! @faroit My review checklist is now complete. As mentioned in the respective issues: there are a few points that can be clarified/improved still, but this meets the...
Maybe add a `squared=True` parameter? That should keep things fairly close with how it's handled elsewhere, e.g. [`sklearn.metrics.mean_squared_error`](https://scikit-learn.org/stable/modules/generated/sklearn.metrics.mean_squared_error.html)