Hayden McAfee

Results 25 issues of Hayden McAfee

Stale FtlClient relay connections may still exist even after a channel subscription is removed, causing the Edge node to potentially send extra unsubscribe events. See here: https://github.com/Glimesh/janus-ftl-plugin/blob/9315b8b045f584e3cfc7e4c65ac761275c679947/src/JanusFtl.cpp#L765 Solution: Edge needs...

If you call `NetworkSocketConnectionTransport::Write(...)` and then immediately `NetworkSocketConnectionTransport::Stop()`, there's a good chance that the bytes you've just queued up to be written will not make it across the wire. This...

bug

1. Orchestrator tells ingest to relay a stream via `JanusFtl::onOrchestratorStreamRelay` 2. JanusFtl calls `FtlClient::ConnectAsync` and waits on the result, blocking the orchestrator thread from processing new messages for as long...

In `FtlServer::onNewControlConnection(...)`, a timeout thread is started that waits a number of seconds and then stops the control connection if it has not yet authenticated. **When the timeout lapses, the...

[This](https://github.com/Glimesh/janus-ftl-plugin/blob/master/JanusFtl.cpp#L222) is probably causing a significant amount of our srtp errors. We should be resetting the rtp context and shutting everything down when we see a hang-up signal. In the...

bug
enhancement

Whoops. #60 resulted in `FTL_SERVICE_METADATAREPORTINTERVALMS` getting ignored, and defaulting to 5000ms.

bug
good first issue

good first issue
ship blocker

We're seeing some warnings, and we ought to address them. ``` ../src/FtlClient.cpp: In member function ‘void FtlClient::RelayPacket(RtpRelayPacket)’: ../src/FtlClient.cpp:108:14: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with...

good first issue

Probably use something like spdlog and just redirect to Janus logging at runtime if we're running inside of Janus. `JANUS_LOG` is getting a bit clunky for us.

Currently we don't respond to RTCP feedback messages indicating that we need to re-transmit packets that may have been lost. We need to.

enhancement