Hayden Adams

Can now add the decorator ```python @nonreentrant(key) ``` https://github.com/ethereum/vyper/pull/1264

Yeah that comes from a vyper bug that wasn't discovered until after Uniswap launch https://github.com/ethereum/vyper/issues/1091

@k06a on transaction fail, yes

Hey @dmilla thanks for the support! I appreciate the gesture, but these contracts do not need to be updated, as we are well underway into building Uniswap V2 in Solidity....

> More broadly speaking, the Uniswap contracts incorrectly assume that the token contract being called will not call out into any third party Imo tokens that do this are inherently...

consider adding a 3rd custom WETH that is also interchangeable, and includes improvements like permit

No problem, let me know if you have any questions!

A Vyper commit from a few days ago broke my pyethereum tests for Uniswap, so I figured I’d try it. For now I switched back to a slightly older Vyper

Good to hear! Well integrated and easy to use testing is super important imo. Vyper + pytest development should be as easy to get started with as Solidity + Truffle.

Totally agree. I already prefer the Vyper dev environment and think it has a lot more potential long term. I just mean they hold your hand in major way when...