v1-contracts icon indicating copy to clipboard operation
v1-contracts copied to clipboard

Support for latest Vyper compiler

Open dmilla opened this issue 6 years ago • 4 comments
trafficstars

Hello!

First of all congrats for Uniswap, amazing project!

I'm starting a project that will be using Uniswap, and I've updated both contracts so they compile with latest Vyper version. Before creating a PR, I'd like to first confirm if this will be a relevant change for the project, and if yes what other critical parts of the project will need to be updated accordingly besides contracts source?

Thanks!

dmilla avatar Nov 17 '19 13:11 dmilla

I just uploaded code in case someone needs it, you can check related PR #44 .

dmilla avatar Nov 27 '19 18:11 dmilla

Hey @dmilla thanks for the support!

I appreciate the gesture, but these contracts do not need to be updated, as we are well underway into building Uniswap V2 in Solidity.

I'd rather keep the Vyper code identical to the deployed code of Uniswap V1

haydenadams avatar Nov 28 '19 04:11 haydenadams

Thanks for your answer, wasn't aware of that, I understand your point @haydenadams !

Out of curiosity, why have you choosed to go back to solidity for Uniswap V2? Where can I follow V2 development?

dmilla avatar Nov 28 '19 11:11 dmilla

good question, why moving from vyper ?

henry-hz avatar Apr 24 '20 15:04 henry-hz