Eliza Weisman

Results 530 comments of Eliza Weisman

> * tracing-appender shouldn't be looking at the suffix of the file to determine if/which compression mechanism is used. I think creating a builder for tracing-appender that allows the user...

@pjankiewicz Hmm, regarding the API design, I think the ideal approach would be adding a new builder type for construcing a rolling appender. I would expect the API to look...

@pjankiewicz > @sw-dev-code Sorry for the delay I had some other priorities. I will get back to it this week. Great, I'm happy to help get this over the finish...

> @hawkw BTW I had a strange issue in reading the compressed log. > > > > ```rust > > let mut s = String::new(); > > let _ =...

Ah, I see the issue --- this is an interaction between how the filter is interpreted and the span generated by the `#[instrument]` macro. `#[instrument]` records all fields as `fmt::Debug`,...

The [`tracing_subscriber::layer` module](https://docs.rs/tracing-subscriber/latest/tracing_subscriber/layer/index.html) has documentation that's intended to provide an introduction to these concepts. I'd love any feedback on what's currently missing from this documentation from your perspective, because we...

I'm somewhat surprised this works; I _thought_ `tracing`'s macros that `instrument` expands to required a literal and not a static reference. But, if this actually generates code that compiles, I'm...

> @hawkw should we close this? I originally opened this PR because I was hoping to get some feedback from users and other maintainers about whether this kind of change...

Yeah, I'd like to consider a breaking release for a couple other changes, so when we do one, we should make sure this actually gets in too.

> Hmm... can we figure out a transition path so we can incrementally start using the new system without having to switch to 0.2 immediately? New `RUSTFLAGS`-based compile-time filtering could...