Eliza Weisman

Results 530 comments of Eliza Weisman

Does Victoria also scrape metrics in the Prometheus/OpenMetrics text format? If so, it should certainly be possible for Victoria to scrape the metrics exported by Linkerd proxies identically to Prometheus.

so, the thing is... ```rust span!( Level::DEBUG, "answering_question" question.answer = answer, question.tricky = true, "the answer to {} is {}.", question, answer ); ``` is _also_ valid.

I don't think removing metadata fields will make a significant impact on binary size. Instead, I think a majority --- or perhaps all --- of the increased binary size you're...

> I'm sure there's others, but do @hawkw @rcoh @robjtede have any comments on whether extensions you use could or could not be `Clone`? The `linkerd` proxy doesn't currently use...

I mean, we could also just "not write code that clones requests" to get that behavior. :)

> > extensions we use would not necessarily be correct to clone. > > That seems like something that can't quite be defined as `Clone` or not. You want that...

@sunng87 just to clarify here, is it the _slice_ that should be owned, or the `NamedField`s that should be owned?

Right, I'm looking into a possible change like this. But, I'm not totally sure if I understand why this change is necessary. If you have a `Vec` of field names,...

@sunng87 let me know if that solution works out for you; I'd like to get this issue figured out soon, because if we do add code to make owned named...

Hmm, I see why you can't borrow the fields here, so you're right that an owned variant might be necessary. Thanks for the example!