Eliza Weisman

Results 530 comments of Eliza Weisman

@hi-rustin that's correct, this change will require an upstream change in `tracing` to expose the numeric index of a `tracing::field::Field`. I'm happy to merge a PR that makes such a...

Hi folks, I'm very excited to let you all know that yesterday, we released [edge-23.4.1](https://github.com/linkerd/linkerd2/releases/tag/edge-23.4.1), a release candidate for Linkerd 2.13, which features initial support for request-level HTTP circuit breaking....

This change makes sense to me. The CI failure is due to a yanked dependency breaking our build with `-Z minimal-versions`, that's not related to this change.

Thanks for working on this! > CC @hawkw does this look right to you? How and where can I add a testcase for this ( I am a first time...

@matthiasbeyer if you don't mind selecting "Allow changes from maintainers", I'm happy to pull the branch and run `rustfmt` on my machine, and then I can merge it? Otherwise, pushing...

Since the dependency on `nu-ansi-term` is not exposed in public APIs, I would happily accept a PR that replaces it with a different crate, provided that the replacement also supports...

Yeah, I think it would be good to document this behavior more clearly. I'd happily merge a PR!

> @hawkw I'd love to get your opinion on the change I've made in the `callsite` module. It seems fine for me (and certainly no tests failing), but I think...

Well, this is extremely strange; the `0.3.18` release on crates.io _should_ be exactly the same as the tagged commit for `tracing-subscriber-0.3.18`...the only difference I can think of is the path...

The `log` feature only emits `log` records if no `tracing` `Subscriber` has ever been set. Your calls to `with_current_subscriber` are setting a subscriber, disabling the `log` crate output. This is...