Eliza Weisman
Eliza Weisman
> @hawkw The previous `Header` layout with `tokio-unstable` and `tracing` enabled also doesn't fit into the cache line on 32-bit systems. > > Can you comment on how important it...
FWIW, the number of `Receiver`s is already tracked in a separate atomic...https://github.com/tokio-rs/tokio/blob/4daeea8cad1ce8e67946bc0e17d499ab304b5ca2/tokio/src/sync/watch.rs#L179-L180 but, that isn't read in operations that also care about the version. Another potential option, which would maintain...
It's worth noting that Mio's `TcpSocket` already exposes some additional socket options that Tokio doesn't expose: - [`SO_REUSEPORT` (on Unix only)](https://github.com/tokio-rs/mio/blob/27fbd5f04bb5f52a4d1c358cf0c04c6074a3d46b/src/net/tcp/socket.rs#L90-L95) - [`SO_LINGER`](https://github.com/tokio-rs/mio/blob/27fbd5f04bb5f52a4d1c358cf0c04c6074a3d46b/src/net/tcp/socket.rs#L104-L107). We may want to expose these as...
Opened tokio-rs/mio#1384 to expose buffer size, and tokio-rs/mio#1385 to expose the keepalive interval. We may also want to add SO_NODELAY...
yeah, i think you're right that the waiter should be in an `UnsafeCell`. this should actually be pretty straightforward to fix, i think. good catch, @kprotty!
This lint sometimes generates false positives; it also sometimes is triggered when a constant is used as an array initializer to initialize an array with an interior-mutable item... We should...
> > > > What about `spawn_local`? Whether to consider to end the current thread when panic in the "local task"? I think inconsistent behavior between `spawn` and `spawn_local` is...
> For the spawn error, we do have additional cases than thread spawning, e.g. "the runtime is shutdown". This makes me think we should introduce a new error type. A...
#4955 is another case where, if we added that kind of API, we would be introducing another error variant that doesn't really map directly to an `io::Error` variant. I think...
> One thought: We don't _necessarily_ need a separate thread for monitoring this. We could make sure that whenever at least one thread is idle, one of the idle threads...