Eliza Weisman
Eliza Weisman
> Thanks for your comments @hawkw! I do think it'd be great to incrementally merge changes into another branch, otherwise the PR is going to take forever. I created the...
@bryangarza > Like, let's say that `valuable` releases a breaking change on the `Visit` trait -- how would we deal with that in `pub fn record(&self, visitor: &mut dyn Visit)`?...
Hmm, yeah, this codegen is not great. It would be nice to be able to enter the span for both any code that happens in the function body before the...
Closing this as I believe it's obsolete and the issue may have already been fixed separately.
> I think it should be possible to use [`sharded_slab::Pool`](https://docs.rs/sharded-slab/latest/sharded_slab/struct.Pool.html) to store the extensions as well as the always-present data, and to do so in a backwards-compatible manner. Yes, a...
@CAD97, if you're interested in working on that, I would _love_ a PR, and I can try to find what I wrote a while ago as a starting point, if...
I definitely want to get an 0.4 out at some point, so if we can come up with a really solid implementation of this that requires a breaking change, I...
> * Should it take `&Dispatch`, or `&mut Dispatch`? it should not take `&mut Dispatch` --- there are no methods on `Dispatch` which require mutable access, so the only thing...
> @hawkw, whoops, I definitely meant to write: > > > Should it take `&self`, or `&mut self`? > > An argument in favor of the method consuming `&mut self`...
It occurs to me that adding an API like this has the unfortunate consequence of making it quite easy to accidentally write memory leaks. In your specific use-case in `tokio-console`,...