Eliza Weisman
Eliza Weisman
(as a side note, you don't need to force push to branches, as all pull requests will be merged by squashing. see https://github.com/tokio-rs/tracing/blob/master/CONTRIBUTING.md#commit-squashing for details.)
no worries, it's nto a big deal!
CI failure is a new clippy warning, unrelated to this change: https://github.com/tokio-rs/tracing/runs/7842367961?check_suite_focus=true I'll fix that on `main`.
> Upon working more with `tracing-glog`, would it be a good idea to expose some of the simpler bits of configuration (e.g., thread names, files, targets) available on [`Format`](https://docs.rs/tracing-subscriber/latest/tracing_subscriber/fmt/format/struct.Format.html) to...
@guswynn any updates on the fix for this? Happy to help get it through!
An env variable can be implemented in user code with the current APIs in `tracing-subscriber` [`fmt::Layer::with_ansi`](https://docs.rs/tracing-subscriber/0.2.15/tracing_subscriber/fmt/struct.Layer.html#method.with_ansi) and [`fmt::SubscriberBuilder::with_ansi`](https://docs.rs/tracing-subscriber/0.2.15/tracing_subscriber/fmt/struct.SubscriberBuilder.html#method.with_ansi). (Sidenote: maybe these should be renamed to `with_colors` or something in 0.3...
We could rename it to `with_ansi_colors` or something, in v0.4. I do think it's also important to be clear that the method _specifically_ enables ANSI formatting escape codes, and not...
> The tests currently fail, and all those printlns in there are because the changed `EnvFilter::enabled` method is not actually called, and I have no idea why. The reason `EnvFilter::enabled`...
> I tried using `directives_for(metadata)` [here](https://github.com/tokio-rs/tracing/pull/2095/files#diff-39b7f14b8285ad4e2a20c40a0a9ec73d51f3bc30e30e147dae0c441ef0e7356dR633), but that doesn't seem to be possible: > `cares_for` compares the span name (`my_span` in the test) with the name of the event metadata...
thinking about this a bit more --- i mentioned in a few places that we might want to completely remove the `FieldSet` and `ValueSet` types, e.g.: > I think we...