Peter Fiddes

Results 142 comments of Peter Fiddes

For the updated roadmap or [v1 milestone,](https://github.com/jetstack/version-checker/milestone/1) see here: https://github.com/jetstack/version-checker/milestone/1 Specifically we tried to set some criteria in the Themes vs Non Themes. The actual issues my change / increase...

Ok so you have CRDs and you now have a new error. Previously it was `connection refused` but now you have "tls: failed to verify certificate: x509: certificate has expired...

The `ClusterIssuer` is available to use by `Certificate` resources from any namespace. However the `Certificate` resource itself is namespaced and cert-manager will only create a `Secret` in the same namespace...

@aburan28 - I appreciate the thought to consolidate the leader election into the installation namespace. However for backwards compatibility I wouldn't remove the option from the chart. I would instead...

@klewan you can actually set contacts and approvers on a `policy` resource in the JSON. Here's a reference example: ```json { "policy": {}, "defaults": {}, "users": [ "tppadmin", "team-1" ],...

~~ToDo: test what happens when the token expires.~~ Addressed [above](https://github.com/cert-manager/cert-manager/pull/7084#issue-2343789554) in "Testing" section.

> @hawksight The E2E tests will be skipped while the PR is marked as draft. These additional Venafi E2E tests can be triggered manually with the following in a GitHub...

/test pull-cert-manager-master-e2e-v1-30-issuers-venafi-tpp

I looked at the log for the failed job and ran the command suggested: `make vendor-go generate-licenses` However it changes a lot of things and I don't think I should...