Will Hawkins

Results 112 comments of Will Hawkins

@LPardue Let me know what you think about the _direction_ of this PR. If you think that it is on the right track, I will gladly do whatever you say...

Sorry it took me so long, @LPardue ! If this version looks okay, I will start in on determining how to handle FFI!

Hello @LPardue! I noticed that we missed an opportunity to add a member function to test whether an unknown transport parameter's id is in the reserved space. I have updated...

I rebased against the updated master to resolve build errors.

@ghedo Thank you for the review! I just talked to @LPardue and I let him know that I will address these bits of feedback tonight! Thank you, again!

I added this small feature so that I could detect whether any implementations are currently advertising support for accurate ECN. I thought that working with quiche was an awesome experience...

I am sorry for the delay! I have started to review but did not get as far as I would have liked! I will (I hope) finish up tomorrow!

On a related note, what do you think about "sprucing up" the disassembler's output with some optional debugging and warning information? Given the program in `artifacts/program-7d9bcc963763cd1f80da6c09dedea38e1435c4e5`, you would see something...

As I said before, thank you *all* for the work that you do maintaining this awesome library. I hope that this added functionality is helpful!