quiche icon indicating copy to clipboard operation
quiche copied to clipboard

lib, qlog: Track and Log Unknown Transport Parameters

Open hawkinsw opened this issue 1 year ago • 1 comments

Track (and make available to qlog for logging) transport parameters and their values that this implementation does not specifically recognize.

hawkinsw avatar Oct 16 '24 14:10 hawkinsw

@LPardue Let me know what you think about the direction of this PR. If you think that it is on the right track, I will gladly do whatever you say so that it meets the high standards of the code that you have already written in this library.

In re: https://github.com/quicwg/qlog/issues/436 and (potentially) https://github.com/quicwg/qlog/issues/176.

hawkinsw avatar Oct 16 '24 14:10 hawkinsw

Sorry it took me so long, @LPardue ! If this version looks okay, I will start in on determining how to handle FFI!

hawkinsw avatar Oct 28 '24 20:10 hawkinsw

LGTM thanks @hawkinsw .

I'd like @ghedo to take a final look over before merging it though

LPardue avatar Nov 25 '24 01:11 LPardue

Hello @LPardue! I noticed that we missed an opportunity to add a member function to test whether an unknown transport parameter's id is in the reserved space. I have updated the PR! Let me know what you think!

(Also, I rebased to make it easier to review).

hawkinsw avatar Jan 16 '25 04:01 hawkinsw

I rebased against the updated master to resolve build errors.

hawkinsw avatar Jan 17 '25 00:01 hawkinsw

@ghedo Thank you for the review! I just talked to @LPardue and I let him know that I will address these bits of feedback tonight! Thank you, again!

hawkinsw avatar Jan 22 '25 17:01 hawkinsw

Added a couple additional minor tweaks (e.g. renamed safe_push -> push) and merged, thanks @hawkinsw!

ghedo avatar Jan 23 '25 10:01 ghedo