Shantanu

Results 430 comments of Shantanu

This is behaviour that there has already been some back and forth on, so I would look at old issues before making a change

This continues to crop up with typeshed pretty regularly. For a lot of return types, typeshed either has to either make a pretty opinionated decision or completely forgo type safety...

Guido's thoughts on the subject: https://mail.python.org/archives/list/[email protected]/message/TTPVTIKZ6BFVWZBUYR2FN2SPGB63Z7PH/ ~~edited out misleading tldr~~ There's probably also some slightly different behaviour when intersecting slightly incompatible types. E.g., for an intersection maybe you'd want to...

Okay, we're down to four failing tests with Python 3.11: ``` FAILED mypyc/test/test_run.py::TestRun::run-misc.test::testCheckVersion FAILED mypyc/test/test_run.py::TestRun::run-classes.test::testProtocol FAILED mypyc/test/test_run.py::TestRun::run-classes.test::testPickling FAILED mypyc/test/test_run.py::TestRun::run-classes.test::testProperty ``` #13125 takes care of testCheckVersion testProperty seems trivial, just a...

@97littleleaf11 any interest in taking a look at the testProtocol failure? :-)

#13206 should fix testProtocol and testPickling beta5 has some new test failures (that are my fault from https://github.com/python/cpython/pull/94948 ), these ones are very easy to fix

Okay, CPython has rolled back changes, see https://github.com/python/cpython/issues/92678 and https://github.com/python/cpython/issues/95589. We should still confirm that with RC or B6 or whatever, we'll just have `testProperty` failing.

Okay, with RC1 we have the following tests failing: ``` testPickling: probably related to https://github.com/python/cpython/issues/70766 (although not sure why #13206 "fixed" this) testProperty: as mentioned above, just a difference in...

Thanks for reporting! I haven't yet tried to confirm, but do let me know if you have an example repro :-)